Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Convert get-ssl-cert to typescript #22447

Merged
merged 6 commits into from
Jul 17, 2020
Merged

chore(gatsby): Convert get-ssl-cert to typescript #22447

merged 6 commits into from
Jul 17, 2020

Conversation

mottox2
Copy link
Contributor

@mottox2 mottox2 commented Mar 20, 2020

Description

Convert get-ssl-cert to typescript

Related Issues

related to #21995

@mottox2 mottox2 requested a review from a team as a code owner March 20, 2020 18:44
@blainekasten blainekasten mentioned this pull request Mar 24, 2020
Closed
pvdz
pvdz previously requested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please resolve the merge conflicts :) 💜

packages/gatsby/src/commands/develop.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/get-ssl-cert.ts Show resolved Hide resolved
packages/gatsby/src/utils/get-ssl-cert.ts Outdated Show resolved Hide resolved
packages/gatsby/src/utils/__tests__/get-ssl-cert.ts Outdated Show resolved Hide resolved
@blainekasten
Copy link
Contributor

@mottox2 This PR is very outdated now :( Sorry we couldn't move faster on it. Would you be able to resolve the conflicts and we'll get it merged?

@blainekasten blainekasten dismissed pvdz’s stale review July 17, 2020 16:47

I took care of them!

blainekasten
blainekasten approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 17, 2020
@gatsbybot gatsbybot merged commit 8b60a27 into gatsbyjs:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mottox2 @blainekasten @pvdz @gatsbybot