Clarify prefix-paths variable. #23309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line (one line, two places) I'm editing was copied from a comment in gatsbyjs#21627 without the surrounding context. This edit provides that context.
|
Looks good! Failing tests are unrelated to this PR, so going to merge it. |
|
Holy buckets, @alexfornuto — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
mxstbr
added a commit
that referenced
this pull request
Apr 22, 2020
* fix(gatsby): Throw error on default export in gatsby-ssr/brows… (#23133) * fix: Handle default export case * heh * fix comment * chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * fix(docs): Using-MDX link (#23288) * fix(docs): Link to apollo blog (#23290) * fix(docs): change gatsby-config mention for global CSS import (#23245) * fix `gatsby-config` mention * chore: format Co-authored-by: gatsbybot <[email protected]> * docs: added details signifying that node fields can be arbitra… (#23106) * added details signifying that node fields can be arbitrary * Update docs/docs/data-fetching.md Co-Authored-By: Kyle Gill <[email protected]> * Update docs/docs/data-fetching.md Co-Authored-By: Kyle Gill <[email protected]> * removed empty line to fix failed linting tests Co-Authored-By: Kyle Gill <[email protected]> Co-authored-by: Kyle Gill <[email protected]> * chore(gatsby): drop the the (#23295) * chore(showcase): Add new sites built by Bejamas to showcase; c… (#23125) * chore(sites): add new sites built by bejamas * chore(creators): update bejamas cover * chore(showcase):Add SofaScore Corporate web to showcase sites (#23128) Co-authored-by: Mario Nikolaus <[email protected]> * fix local links (#23149) * chore(docs): Reference new ComponentModel component rather than generic LayerModel (#23241) * Reference new ComponentModel component rather than generic LayerModel * Remove use of t macro from layer models * Half-fixing lingui code * Revert "Half-fixing lingui code" This reverts commit 64f052a. * Remove Lingui from layer-model * fix(www): fix sidebar (#23301) * fix(www): fix sidebar * Update sidebar.js * fix(recipes): Fix shadow-file resource for scoped NPM packages & re-enable e2e testing for resources (#23274) * fix(recipes): Fix shadow-file resource for scoped NPM packages * WILL SLASH FIX WINDOWS??? * Add missing code block * Try again * hmmm joinPath maybe is the problem * More fixes * try reenabling tests * disable colors in diffs * Fix npm script test * Why do these keep changing all the time?? * Use parsed value for the plan * Disable Chalk colors on unit tests so match local ones * Update packages/gatsby-recipes/src/providers/utils/get-diff.js Co-Authored-By: John Otander <[email protected]> Co-authored-by: John Otander <[email protected]> Co-authored-by: gatsbybot <[email protected]> * chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * chore(starters): add gatsby-starter-ecommerce (#23037) * chore(starters): add gatsby-starter-ecommerce * chore(starters): add gatsby-starter-ecommerce Co-authored-by: gatsbybot <[email protected]> * Add site Interficie Internet Services (#23130) * Add site Interficie Internet Services * Correct JavaScript cammelcase * Prettier format Co-authored-by: Obinna Ekwuno <[email protected]> Co-authored-by: gatsbybot <[email protected]> * fix brand names (#23142) * fix(blog): remove local domain (#23141) * fix remove local domain * fix local domain * fix local domain * fix remove local domain * fix for linter * Create paul scanlon 100 days of Gatsby blog post and add assets (#23294) * Create paul scanlon 100 days of Gatsby blog post and add assets * fix frontmatter * fix frontmatter issue and ad relative links * fix typos and spacing issues * Update docs/blog/2020-04-20-paulie-scanlons-journey-of-100-days/index.md Co-Authored-By: LB <[email protected]> Co-authored-by: Laurie Barth <[email protected]> Co-authored-by: LB <[email protected]> * Clarify prefix-paths variable. (#23309) The line (one line, two places) I'm editing was copied from a comment in #21627 without the surrounding context. This edit provides that context. Co-authored-by: gatsbybot <[email protected]> * chore(showcase):Add shreysachdeva.tech to showchase (#23032) * Add shreysachdeva.tech to sites.yml **Description** Added the details of my personal website shreysachdeva.tech. **Documentation** No documentation **Related Issues** N/A * chore: format Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Obinna Ekwuno <[email protected]> * fix(www): Fix sidebar expansion behavior (#23325) * [gatsby-plugin-manifest] Generate a 32x32 favicon instead of generating from first manifest icon (#23077) * Decouple favicons from manifest icons * Update packages/gatsby-plugin-manifest/README.md * Replace include_favicon undefined check with nullish coalescing operator Co-Authored-By: Alex Moon <[email protected]> * Assert gatsby-plugin-manifest generates favicon PNG (unless include_favicon option is false) * Don't mock createContentDigest in gatsby-plugin-manifest's gatsby-ssr tests (to be consistent with gatsby-node tests) * Tweak a comment Co-authored-by: LB <[email protected]> Co-authored-by: Alex Moon <[email protected]> * Use mutations in Gatsby Admin * Remove stray console.logs * chore(gatsby-recipes): Update README typo (#23333) Fixed typo in README.md * fix(gatsby): Check for files before delete action when using GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES (#23219) * Check for files before delete action * fix lint issues * fix lint issues and add return type to checkFolderHasContent * rename check function Co-authored-by: gatsbybot <[email protected]> * Install plugins as prod dependencies * chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Add Besoegsvenner site to showcase (#23172) * Add Besoegsvenner site to showcase 50.000 elderly people in Denmark feel lonely. This project seeks to inform people to become visitor friends ("Besøgsven" in Danish) to help fight loneliness and bring new friendships in to the world. * Update sites.yml Co-authored-by: Obinna Ekwuno <[email protected]> Co-authored-by: gatsbybot <[email protected]> * chore(benchmarks): Add Drupal data updater script to update benchmark data (#23242) * Add Drupal data updater script to update benchmark data * Remove console.log statement Co-authored-by: gatsbybot <[email protected]> * Make TypeScript happy * fix(gatsby): fix Uncaught TypeError in navigation.js (#23196) * Add null check to address #21263 #21263 is an issue many people are arriving at for a variety of reasons. Since the code contains this logic on the following line: ``` if (pageHeadings && pageHeadings.length) { ``` There should be no issue in seeing if `document.getElementById(`gatsby-focus-wrapper`) exists first before attempting to look up `getElementsByTagName`. * Update packages/gatsby/cache-dir/navigation.js Co-Authored-By: Vladimir Razuvaev <[email protected]> * chore: format Co-authored-by: Vladimir Razuvaev <[email protected]> Co-authored-by: gatsbybot <[email protected]> * Add support for file argument in remark plugins for gatsby-plugin-mdx (#21489) * chore(gatsby-cli) Migrate remaining files in reporters/logger/ink to Typscript (#22782) * Migrate remaining files in gatsby-cli/reporters/logger/ink to TS * Rename "IProps" to something more contextual Extend interface parameter individually instead of using utility * Clean up after merging the redux master changes Co-authored-by: Blaine Kasten <[email protected]> * Fix Drupal data update script (#23349) * Add noop data update scripts for all benchmarks (#23352) * Add noop data update scripts for all CMS benchmarks * Add data update to remainder of benchmarks * chore(babel-preset-gatsby): Convert dependencies to TS (#22038) Co-authored-by: Blaine Kasten <[email protected]> * fix(gatsby): Improve error message when calling useStaticQuery without graphql (#23189) * Add warning message for a long queries (#23261) * Add warning message for a long queries * Change timeout to 15 seconds * Replace console with report * Print out queryJob.componentPath instead of page.internalComponentName * Add new info in the warning message Co-authored-by: gatsbybot <[email protected]> * refactor(gatsby): Convert inference metadata to TypeScript (#23264) * refactor(inference-metadata): Convert to TypeScript * Remove unused variable * Forgot some types * refactor(type-conflict-reporter): Node description After tightening the original util function to return a string only, it seemed sensible to convert that to use nullish coalescing. At that point, seeing the function is only used in a single place and not exported, I inlined it. * refactor(inference-metadata): Interface renaming * fix: Extract ValueType type * refactor: Change type from unknown to object * Corrected types, but left the code alone * Removed redundant comments * Update README.md (#23357) * feat(gatsby-remark-images): support markdownCaptions in mdx + fix for remark (#21188) * pass compiler to gatsby-remark-* plugins in the mdx plugin * make getImageCaption async * use async mdx compiler * fix for using compiler * don't mutate the node multiple times * convert markdown ast to html ast Co-authored-by: vladar * chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Fix lint errors * Fix TypeScript unused declaration error * Fix linting Co-authored-by: Lennart <[email protected]> Co-authored-by: Jeremy Albright <[email protected]> Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Elijah <[email protected]> Co-authored-by: Kyle Gill <[email protected]> Co-authored-by: Peter van der Zee <[email protected]> Co-authored-by: Michał Zieliński <[email protected]> Co-authored-by: Mario Nikolaus <[email protected]> Co-authored-by: Mario Nikolaus <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: Aisha Blake <[email protected]> Co-authored-by: Ward Peeters <[email protected]> Co-authored-by: Kyle Mathews <[email protected]> Co-authored-by: John Otander <[email protected]> Co-authored-by: Lorenzo GM <[email protected]> Co-authored-by: aperacaula <[email protected]> Co-authored-by: Obinna Ekwuno <[email protected]> Co-authored-by: Michelle Gienow <[email protected]> Co-authored-by: Laurie Barth <[email protected]> Co-authored-by: LB <[email protected]> Co-authored-by: Alex Fornuto <[email protected]> Co-authored-by: Shrey Sachdeva <[email protected]> Co-authored-by: Nat Alison <[email protected]> Co-authored-by: Owen <[email protected]> Co-authored-by: Alex Moon <[email protected]> Co-authored-by: Marcus Lyons <[email protected]> Co-authored-by: Stuart Rayson <[email protected]> Co-authored-by: Michal Piechowiak <[email protected]> Co-authored-by: Jacob Packert <[email protected]> Co-authored-by: Shane Thomas <[email protected]> Co-authored-by: nick shook <[email protected]> Co-authored-by: Vladimir Razuvaev <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Arthur <[email protected]> Co-authored-by: Blaine Kasten <[email protected]> Co-authored-by: Nicholas Duffy <[email protected]> Co-authored-by: Michaël De Boey <[email protected]> Co-authored-by: Rebenkov Aleksey <[email protected]> Co-authored-by: Ross Hendry <[email protected]> Co-authored-by: Khaled Garbaya <[email protected]> Co-authored-by: Mathieu Dutour <[email protected]> Co-authored-by: Sidhartha Chatterjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The line (one line, two places) I'm editing was copied from a comment in #21627 without the surrounding context. This edit provides that context.
Documentation
yes
Related Issues
Finishes #21627 by looking at the docs updates from an impartial perspective.