Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): migrate static-query-components reducer to TypeScript #23475

Merged
merged 1 commit into from
Apr 27, 2020
Merged

chore(gatsby): migrate static-query-components reducer to TypeScript #23475

merged 1 commit into from
Apr 27, 2020

Conversation

hiwelo
Copy link
Contributor

@hiwelo hiwelo commented Apr 25, 2020

Description

This commit migrates the static-query-components reducer to TypeScript with few adjustments to the existing IGatsbyState interface.

The main adjustment is the update of the type of the key used for the map storing each static query from number to string.
This change reflect the fact that the key is described as being the id field of the interface, and this field is described as a string in the object definition.

Related Issues

Relates to #21995

This commit migrates the `static-query-components` reducer to
TypeScript with few adjustments to the existing IGatsbyState
interface.

The main adjustment is the update of the type of the key used for
the map storing each static query from `number` to `string`.
This change reflect the fact that the key is described as being
the `id` field of the interface, and this field is described as a
`string` in the object definition.
@hiwelo hiwelo marked this pull request as ready for review April 25, 2020 12:12
@hiwelo hiwelo requested a review from a team as a code owner April 25, 2020 12:12
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten merged commit bb38afd into gatsbyjs:master Apr 27, 2020
@gatsbot
Copy link

gatsbot bot commented Apr 27, 2020

Holy buckets, @hiwelo — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@hiwelo hiwelo deleted the ts-migration/reducer-static-query-components branch April 27, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants