chore(gatsby): migrate webpack reducer to TS #23566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the webpack reducer to TypeScript by creating a series of new types for the reducer and its actions. In order to use the `merge` function provided by the `webpack-merge` package, I had to add its typings from Definitely Typed.
hiwelo
force-pushed
the
ts-migration/webpack-reducer
branch
from
451f5c3
to
9b1b0c2
Compare
LekoArts
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit migrates the webpack reducer to TypeScript by creating a series of new types for the reducer and its actions.
In order to use the
mergefunction provided by thewebpack-mergepackage, I had to add its typings from Definitely Typed (@types/webpack-merge).Related Issues
Relates to #21995