chore(docs): Updated read-me with punctuation where necessary #23649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AishaBlake
reviewed
Apr 30, 2020
packages/gatsby-image/README.md
Outdated
| 1. Images that have a _fixed_ width and height | ||
| 2. Images that stretch across a _fluid_ container | ||
| 1. Images that have a _fixed_ width and height. | ||
| 2. Images that stretch across a _fluid_ container. |
There was a problem hiding this comment.
I'm on board with correcting punctuation in general but periods should only be added to the end of a list item if the text in that list item is a complete sentence.
There was a problem hiding this comment.
oh, thanks for the enlightenment I really appreciate it.
|
@Olanetsoft, thanks for the contribution! For future reference, PRs should always have descriptions. |
AishaBlake
added
the
type: documentation
AishaBlake
changed the title
AishaBlake
approved these changes
May 6, 2020
There was a problem hiding this comment.
I went ahead and removed those periods myself so that we could get this in. Thanks for the contribution, @Olanetsoft!
|
You are welcome |
This was referenced Sep 1, 2021
This was referenced Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Related Issues