Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): convert build to typescript #23695

Merged
merged 8 commits into from
May 5, 2020
Merged

chore(gatsby): convert build to typescript #23695

merged 8 commits into from
May 5, 2020

Conversation

devrchancay
Copy link
Contributor

Description

Port src/commands/build.js to TypeScript

Related Issues

Related to #21995

@devrchancay devrchancay requested a review from a team as a code owner May 2, 2020 08:21
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 2, 2020
@blainekasten blainekasten mentioned this pull request May 2, 2020
Closed
ascorbic
ascorbic suggested changes May 4, 2020
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great. Just a few changes needed.

packages/gatsby/src/commands/build.ts Outdated Show resolved Hide resolved
packages/gatsby/src/commands/build.ts Outdated Show resolved Hide resolved
packages/gatsby/src/commands/build.ts Outdated Show resolved Hide resolved
packages/gatsby/src/commands/build.ts Show resolved Hide resolved
@ascorbic ascorbic added status: inkteam assigned and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 4, 2020
@ascorbic ascorbic self-assigned this May 4, 2020
@devrchancay devrchancay requested a review from ascorbic May 4, 2020 15:52
@devrchancay
Copy link
Contributor Author

@ascorbit thanks for your comments, could you check again?

ascorbic
ascorbic approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good.

@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 5, 2020
@gatsbybot gatsbybot merged commit c6f57c2 into gatsbyjs:master May 5, 2020
@muescha muescha mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees

@ascorbic ascorbic

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devrchancay @ascorbic @gatsbybot