Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Convert pagination to TypeScript #23717

Merged
merged 3 commits into from
May 6, 2020

Conversation

alisson-suzigan
Copy link
Contributor

Description

This PR converts the packages/gatsby/src/schema/types/pagination.ts file to TypeScript and its related import in the packages/gatsby/src/schema/schema.js file.

Documentation

No changes required.

Related Issues

Related to #21995

@alisson-suzigan alisson-suzigan requested a review from a team as a code owner May 3, 2020 16:04
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 3, 2020
@alisson-suzigan alisson-suzigan changed the title Ts/pagination chore(gatsby): Convert pagination to TypeScript May 3, 2020
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 4, 2020
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a few requests

packages/gatsby/src/schema/types/pagination.ts Outdated Show resolved Hide resolved
packages/gatsby/src/schema/types/pagination.ts Outdated Show resolved Hide resolved
packages/gatsby/src/schema/types/pagination.ts Outdated Show resolved Hide resolved
packages/gatsby/src/schema/types/pagination.ts Outdated Show resolved Hide resolved
@ascorbic ascorbic self-assigned this May 5, 2020
@ascorbic
Copy link
Contributor

ascorbic commented May 6, 2020

Great stuff. Thanks!

@ascorbic ascorbic merged commit f35545e into gatsbyjs:master May 6, 2020
@gatsbot
Copy link

gatsbot bot commented May 6, 2020

Holy buckets, @alisson-suzigan — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants