Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Migrate reducers/index to TypeScript #23877

Merged
merged 21 commits into from
Jun 2, 2020
Merged

chore(gatsby): Migrate reducers/index to TypeScript #23877

merged 21 commits into from
Jun 2, 2020

Conversation

alisson-suzigan
Copy link
Contributor

@alisson-suzigan alisson-suzigan commented May 7, 2020 •
edited
Loading

Description

This PR converts the following files to TS:

  • packages/gatsby/src/redux/index.ts

Related Issue

Related to #21995

@alisson-suzigan alisson-suzigan requested a review from a team as a code owner May 7, 2020 17:50
@alisson-suzigan alisson-suzigan self-assigned this May 7, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 7, 2020
@alisson-suzigan alisson-suzigan added type: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 7, 2020
@alisson-suzigan alisson-suzigan marked this pull request as draft May 7, 2020 19:27
@alisson-suzigan alisson-suzigan changed the title Ts/reducers index chore(gatsby): Migrate reducers/index to TypeScript May 7, 2020
@blainekasten blainekasten mentioned this pull request May 8, 2020
Closed
@alisson-suzigan alisson-suzigan marked this pull request as ready for review May 9, 2020 20:30
@alisson-suzigan alisson-suzigan added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 13, 2020
@pieh pieh added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 14, 2020
@alisson-suzigan alisson-suzigan requested a review from pieh June 1, 2020 21:20
@pieh pieh self-assigned this Jun 1, 2020
pieh
pieh approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patience and the PR @alisson-suzigan!

@pieh pieh merged commit 3aec087 into gatsbyjs:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees

@pieh pieh

@alisson-suzigan alisson-suzigan

Labels
status: needs core review Currently awaiting review from Core team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alisson-suzigan @pieh