Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Migrate type-builders to TypeScript #23892

Merged
merged 3 commits into from
Jul 17, 2020
Merged

chore(gatsby): Migrate type-builders to TypeScript #23892

merged 3 commits into from
Jul 17, 2020

Conversation

PerfectPan
Copy link
Contributor

Description

migrate gatsby/src/schema/types/type-builders to TypeScript

Related Issues

Related to #21995

@PerfectPan PerfectPan requested a review from a team as a code owner May 8, 2020 05:55
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 8, 2020
@blainekasten blainekasten mentioned this pull request May 8, 2020
Closed
@pvdz pvdz added type: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 8, 2020
@pvdz
Copy link
Contributor

pvdz commented May 8, 2020

(I'm going to put this in Draft mode. Please run yarn typecheck locally and address the reported problems then set the PR back to review mode. Thank you! 💜 )

@pvdz pvdz marked this pull request as draft May 8, 2020 10:48
@PerfectPan
Copy link
Contributor Author

(I'm going to put this in Draft mode. Please run yarn typecheck locally and address the reported problems then set the PR back to review mode. Thank you! )

OK, I will, thx

@PerfectPan PerfectPan marked this pull request as ready for review May 8, 2020 16:29
blainekasten
blainekasten approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 17, 2020
@gatsbybot gatsbybot merged commit 2ef310b into gatsbyjs:master Jul 17, 2020
@PerfectPan PerfectPan deleted the migrate-ts branch July 17, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PerfectPan @pvdz @blainekasten @gatsbybot