Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-cli): migrate loggers/ipc to typescript #23960

Merged
merged 4 commits into from
May 19, 2020

Conversation

anoriqq
Copy link
Contributor

@anoriqq anoriqq commented May 10, 2020

Description

This PR converts packages/gatsby-cli/src/reporter/loggers/ipc/index.js to TypeScript
And related import on packages/gatsby-cli/src/reporter/start-logger.ts

Related Issues

Related to #21995

@anoriqq anoriqq requested a review from a team as a code owner May 10, 2020 13:26
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 10, 2020
@ascorbic ascorbic added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 11, 2020
it could be less bound to that in the future
in order not to mutate the underlying object
@anoriqq
Copy link
Contributor Author

anoriqq commented May 15, 2020

@blainekasten Thank you for your kind review!
I was agreed with all the comments so I fixed it!

@anoriqq anoriqq requested a review from blainekasten May 16, 2020 03:14
@blainekasten blainekasten self-assigned this May 18, 2020
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: needs core review Currently awaiting review from Core team member labels May 19, 2020
@gatsbybot gatsbybot merged commit da09706 into gatsbyjs:master May 19, 2020
@gatsbot
Copy link

gatsbot bot commented May 19, 2020

Holy buckets, @anoriqq — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@anoriqq anoriqq deleted the ts-migrate/loggers-ipc branch May 19, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants