fix(gatsby): Protect about possibly missing context in graphql #24108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
reviewed
May 15, 2020
Co-authored-by: Ward Peeters <[email protected]>
wardpeet
changed the title
pieh
reviewed
May 15, 2020
delete-merged-branch
bot
deleted the
protect-about-possibly-missing-context
branch
Kornil
pushed a commit
to Kornil/gatsby
that referenced
this pull request
May 15, 2020
…yjs#24108) * Guard against possibly missing context in resolver * Warn about bad resolver invocations * Add warning * Update packages/gatsby/src/schema/resolvers.ts Co-authored-by: Ward Peeters <[email protected]> * Fix typo Co-authored-by: Ward Peeters <[email protected]>
gatsbybot
pushed a commit
that referenced
this pull request
May 18, 2020
* Initial conversion * Add ISetBabelPluginAction * Fix naming * Add missing actions * Add missing plugin type * Convert babelrc test file to TS * COnvert snap file as well * fix(gatsby): Protect about possibly missing context in graphql (#24108) * Guard against possibly missing context in resolver * Warn about bad resolver invocations * Add warning * Update packages/gatsby/src/schema/resolvers.ts Co-authored-by: Ward Peeters <[email protected]> * Fix typo Co-authored-by: Ward Peeters <[email protected]> * chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * perf(gatsby): enable fast filters for `in` comparator (#24095) * chore(release): Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Co-authored-by: Mikhail Novikov <[email protected]> Co-authored-by: Ward Peeters <[email protected]> Co-authored-by: Peter van der Zee <[email protected]> Co-authored-by: Peter van der Zee <[email protected]>
LekoArts
removed
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This defensively protects about context/info missing in resolver invocation and warns about that, because it's potentially breaking.
Documentation
Related Issues
Fixes #24100