chore(gatsby): convert inference-metadata to typescript #24381
Conversation
gatsbot
bot
added
the
status: triage needed
| state[type] = deleteNode(state[type], { fields: previousFields }) | ||
| state[type] = addNode(state[type], { fields: node.fields }) | ||
| state[type] = deleteNode(state[type], { ...node, fields: previousFields }) | ||
| state[type] = addNode(state[type], { ...node, fields: node.fields }) |
There was a problem hiding this comment.
These 2 changes have the potential to affect production code as we are now sending a full node instead of just fields. I based this on the fact that the action themselves (deleteNode and addNode) are already typed and coded to accept a full node as second parameter.
Please let me know if this change is acceptable or how I can write it better.
There was a problem hiding this comment.
This feels correct, so it's just a matter of if tests will pass correctly with this change. Thanks for figuring this out!
There was a problem hiding this comment.
Tests seem to pass nicely so it should be all good, I just wanted to make sure this change was seen.
lannonbr
removed
the
status: triage needed
…atsby-inference-metadata
…atsby-inference-metadata
| } | ||
| } | ||
|
|
||
| module.exports = ( |
There was a problem hiding this comment.
this should be a named export and update the import reference.
e.g.
export function inferenceMetadataReducer(state, action) { .... }…atsby-inference-metadata
|
Thank you for the review @blainekasten, I've addressed your feedback, feel free to resolve the conversations if you are ok with the new code ✔️ |
…atsby-inference-metadata
* Convert file & add missing actions * Address feedback
Convert
inference-metadatareducer to TypeScript.Related Issues
#21995