Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __BASE_PATH__ definition to storybook config #25643

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Add __BASE_PATH__ definition to storybook config #25643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44a6a83
Add __BASE_PATH__ definition to storybook config
nabeelvalley Jul 9, 2020
fd10c2e
Globals need not be defined for Storybook Docs
nabeelvalley Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions docs/docs/visual-testing-with-storybook.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ global.___loader = {
hovering: () => {},
}

// __PATH_PREFIX__ is used inside gatsby-link an other various places. For storybook not to crash, you need to set it as well.
global.__PATH_PREFIX__ = ""

// Navigating through a gatsby app using gatsby-link or any other gatsby component will use the `___navigate` method.
// In Storybook it makes more sense to log an action than doing an actual navigate. Checkout the actions addon docs for more info: https://github.com/storybookjs/storybook/tree/master/addons/actions.

Expand Down