chore: add tests to static-query filepaths #25978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: StaticQuery
status: needs core review
wardpeet
force-pushed
the
fix/static-query-windows
branch
from
536571b
to
834c0ff
Compare
sidharthachatterjee
approved these changes
Jul 24, 2020
sidharthachatterjee
added
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows static query paths generation is broken. Gatsby uses slash utility to convert component paths to unix based ones. Webpack has windows file paths so they never match.
I added a simple test to it to illustrate the problem and the fix. The feature itself has great e2e coverage so that's why this is just a simple test.
Documentation
Related Issues
Fixes #25909
Fixes #25920
Fixes #25949