chore: use npm-packlist to calculate packed files in cleanup-script #26657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
force-pushed
the
chore/cleanup-script
branch
from
181f105
to
cb5a3ca
Compare
wardpeet
changed the title
wardpeet
changed the title
wardpeet
changed the title
vladar
approved these changes
Aug 28, 2020
vladar
removed
the
status: triage needed
|
@vladar it doesn't take care of things like README.md, main scripts being ignored by default, ... |
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed clean-scripts directive to use npm-packlist to figure out the right files instead our own logic. This takes care of README.md, package.json, main, ...