Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-remark-images): allow strings for the wrapperStyle option #27912

Merged
merged 2 commits into from
Nov 9, 2020
Merged

fix(gatsby-remark-images): allow strings for the wrapperStyle option #27912

merged 2 commits into from
Nov 9, 2020

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Nov 9, 2020 •
edited
Loading

wrapperStyle also supports strings (in fact, the default option is a string!).

@mxstbr mxstbr requested a review from a team as a code owner November 9, 2020 09:40
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 9, 2020
@mxstbr mxstbr mentioned this pull request Nov 9, 2020
Closed
@mxstbr mxstbr requested a review from a team November 9, 2020 09:44
pvdz
pvdz previously approved these changes Nov 9, 2020
View reviewed changes
mfrachet
mfrachet approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@mfrachet mfrachet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me 🚀 👍🏻

@wardpeet wardpeet added hotfix topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 9, 2020
@wardpeet wardpeet merged commit d64603e into master Nov 9, 2020
@wardpeet wardpeet deleted the remark-images/wrapper-style-string branch November 9, 2020 12:05
vladar pushed a commit that referenced this pull request Nov 9, 2020
@mxstbr @vladar
fix(gatsby-remark-images): allow strings for the wrapperStyle option (#…
12271d7 
…27912)

(cherry picked from commit d64603e)
@vladar vladar mentioned this pull request Nov 9, 2020
Merged
vladar added a commit that referenced this pull request Nov 9, 2020
@vladar
fix(gatsby-remark-images): allow strings for the wrapperStyle option (#…
05b8838 
…27912) (#27919)

(cherry picked from commit d64603e)
@vladar
Copy link
Contributor

vladar commented Nov 9, 2020

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrachet mfrachet mfrachet approved these changes

@wardpeet wardpeet wardpeet approved these changes

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mxstbr @vladar @pvdz @wardpeet @mfrachet