-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): don't double run cypress tests #28171
Conversation
I'll just say that I don't love the extra abstraction that I add here (script that replaces |
Ok, from some chatting - I will drop calling
|
…ng new cypress run command helper
… job using new cypress run command helper" This reverts commit db0c1c5.
28ab082
to
b51d262
Compare
Co-authored-by: gatsbybot <[email protected]>
This hopefully fixes failing cypress tests running twice in CI due to lovely
"cy:run": "(is-ci && cypress run --browser chrome --record) || cypress run --browser chrome"
npm scripts we use (--record
seems problematic when not used withCYPRESS_PROJECT_ID
andCYPRESS_RECORD_KEY
env varsTargets #28169 which should be much more straight forward#28169 was merged, so targetsmaster
branch now