fix(gatsby-react-router-scroll): Respect hash as source of truth for scroll position (#28555) #28560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sidharthachatterjee
removed
the
status: triage needed
|
Marking as draft for now due to my concerns (mostly make sure that we don't trade one problem for another here). We also recently had another scroll related change - #27384 and not sure if there is any connection between them or not |
|
The other PR was not touching the codepath with |
|
This went out in 2.29, so I'll close this PR as there is no point in having this open anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #28555 to the 2.28 release branch
(cherry picked from commit a066a71)