Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-plugin-image): Unflag remote images #29032

Merged
merged 1 commit into from
Jan 14, 2021
Merged

chore(gatsby-plugin-image): Unflag remote images #29032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/gatsby-plugin-image/src/node-apis/image-processing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,11 @@ export async function writeImages({
async ([hash, { src, ...args }]) => {
let file: FileSystemNode | undefined
let fullPath
if (process.env.GATSBY_EXPERIMENTAL_REMOTE_IMAGES && isRemoteURL(src)) {
if (isRemoteURL(src)) {
let createRemoteFileNode
try {
;({ createRemoteFileNode } = require(`gatsby-source-filesystem`))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know, @laurieontech. This is just easier to read.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I agree, don’t worry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, I'm grateful that I now know how to do it!

createRemoteFileNode = require(`gatsby-source-filesystem`)
.createRemoteFileNode
} catch (e) {
reporter.panic(`Please install gatsby-source-filesystem`)
}
Expand Down