[gatsby-source-contentful] Remove default crop focus #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit cb1bf35 |
|
Deploy preview ready! Built with commit 05ed07d |
|
Deploy preview ready! Built with commit cb1bf35 |
|
Makes sense! Which commit added the faces fallback! |
|
Glad to hear Gatsby is working well for ya! |
|
@KyleAMathews they were added here: 14bfcb1 |
|
Huh, no idea what I was seeing! Thanks for the PR! |
|
Hiya @sarahatwork! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
|
Thanks @jlengstorf! I claimed some discount codes and have joined the org 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the great library! Three weeks into a Gatsby project and loving it so far.
On my current project, I ran into an issue where I'm unable to specify that Contentful use its default (center) focus for cropping images. When I don't apply a focus property,
facesis applied automatically 😬This PR removes the default
facescrop focus applied to Contentful image queries. The original commit where this content was added mentioned it was necessary to trigger a crop, but I haven't found this to be true. Let's look at the image from the tests. Here's the original:The code on
mastergenerates a query like this: http://images.contentful.com/ubriaw6jfhm1/10TkaLheGeQG6qQGqWYqUI/5421d3108cbb699561acabd594fa2cb0/ryugj83mqwa1asojwtwb.jpg?w=450&h=399&q=50&fit=fill&f=facesWhen we remove the focus option, we still get a cropped photo, but it's cropped to the center of the image: http://images.contentful.com/ubriaw6jfhm1/10TkaLheGeQG6qQGqWYqUI/5421d3108cbb699561acabd594fa2cb0/ryugj83mqwa1asojwtwb.jpg?w=450&h=399&q=50&fit=fill