Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Remove deprecated gatsby-browser APIs #29248

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 28, 2021

Description

This removes getResourcesForPathnameSync, getResourcesForPathname, and replaceComponentRenderer.

Documentation

Related Issues

[ch23864]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 28, 2021
@LekoArts LekoArts added topic: internal and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 28, 2021
@LekoArts LekoArts changed the title gatsby: Remove replaceComponentRenderer gatsby: Remove deprecated gatsby-browser APIs Jan 28, 2021
@LekoArts LekoArts added the topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) label Jan 29, 2021
@LekoArts LekoArts marked this pull request as ready for review February 2, 2021 10:05
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mostly just removing (or in the case of the docs renaming) things. Like #29186 (review) I'm not sure how this should be merged in but this seems like a straightforward change 🙂

@LekoArts LekoArts changed the title gatsby: Remove deprecated gatsby-browser APIs chore(gatsby): Remove deprecated gatsby-browser APIs Feb 9, 2021
@LekoArts LekoArts merged commit 182d3de into master Feb 9, 2021
@LekoArts LekoArts deleted the v3/gatsby-browser branch February 9, 2021 09:10
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants