Move imported css/sass/less before css-in-js styles #2952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've heard several people asking why they couldn't override their global styles with their css-in-js styles. This is a tricky issue because there's not a "right" answer. This could potentially trip up people who do globals with typography.js (css-in-js) and then wonder why they can't override the styles with their postcss setup 🤷 Thoughts?
|
Deploy preview ready! Built with commit e17c5cb |
|
Deploy preview ready! Built with commit e17c5cb |
|
I guess I could live with fixing the changes from global Typography if there's flexibility to be able to override global styling through |
|
Eh, not sure there's a right answer |
This was referenced Jan 26, 2022
This was referenced Jun 8, 2022
This was referenced Jun 8, 2022
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've heard several people asking why they couldn't override their global
styles with their css-in-js styles.
This is a tricky issue because there's not a "right" answer. This could
potentially trip up people who do globals with typography.js (css-in-js)
and then wonder why they can't override the styles with their postcss
setup 🤷
Thoughts?