Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-gatsby-cloud): Remove sibling detection code and rely on match paths #29610

Merged

Conversation

sidharthachatterjee
Copy link
Contributor

This cleans up and removes our custom static sibling detection code and instead relies on Gatsby and the match path it generates

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 19, 2021
@LekoArts LekoArts added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 22, 2021
dmccraw
dmccraw previously approved these changes Feb 23, 2021
Copy link
Contributor

@dmccraw dmccraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 23, 2021
@gatsbybot gatsbybot merged commit 6016c26 into master Feb 23, 2021
@gatsbybot gatsbybot deleted the sid/ch25298/routes-with-multiple-nested-params-do-not branch February 23, 2021 16:27
ascorbic pushed a commit that referenced this pull request Feb 24, 2021
…ly on match paths (#29610)

* Remove sibling detection code and rely on match paths

* Update snapshot

Co-authored-by: gatsbybot <[email protected]>
(cherry picked from commit 6016c26)
@ascorbic
Copy link
Contributor

@sidharthachatterjee Something is wrong in the release branch. The whole package has disappeared, and no combination of git logs seems to indicate where and how. Could you either find out how, or just open a new PR to add the plugin again!

@sidharthachatterjee
Copy link
Contributor Author

@ascorbic Here you go #29738

@ascorbic
Copy link
Contributor

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants