Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): use params from yargs and don't check process.argv #29648

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Feb 21, 2021

Description

just cleaning things up, --log-pages and --write-to-file are handled by yargs, so let's not check process.argv separately

Related Issues

#29548 (comment)
[ch25550]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 21, 2021
@@ -30,7 +30,6 @@ import {
showFeedbackRequest,
showSevenDayFeedbackRequest,
} from "../utils/feedback"
import * as buildUtils from "./build-utils"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to PR, just noticed it was imported and no longer used in this file

@pieh pieh added topic: build Related to the Gatsby build process and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 21, 2021
@wardpeet wardpeet merged commit e3a7be3 into master Feb 21, 2021
@wardpeet wardpeet deleted the v3/dont-check-proceess-argv-use-params-from-yargs branch February 21, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to the Gatsby build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants