Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set prettyHost to 0.0.0.0 instead of localhost #2960 #2970

Closed
wants to merge 1 commit into from
Closed

set prettyHost to 0.0.0.0 instead of localhost #2960 #2970

wants to merge 1 commit into from

Commits on Nov 20, 2017

  1. set prettyHost to 0.0.0.0 instead of localhost #2960

    in /packages/gatsby/src/commands/develop.js
    L258-259
    ```
    if (isUnspecifiedHost) {
      prettyHost = `0.0.0.0`
    ```
    
    This resolves CORS blocking HMR by printing
    `Local:            http://0.0.0.0:8000/`
    to the terminal after `gatsby develop` is run instead of
    `Local:            http://localhost:8000/`
    
    This may not be ideal resolution of the issue and may break
    something else. Perhaps a different, deeper fix is needed.
    See testing comments in #2960.
    
    Also in packages/gatsby-source-filesystem/index.js
    L3
    ```
    var fs = require(`fs-extra`);
    ```
    got transformed to
    ```
    const fs = require(`fs-extra`);
    ```
    I am thinking during `yarn bootstrap` or `gatsby-dev`, still have 100%
    tests passing as before and it’s late so gonna commit this and revisit
    in the morning.
    rdela committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    dbc49d6 View commit details
    Browse the repository at this point in the history