-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjust npm release dist tag for v2 #30090
Conversation
@@ -146,7 +146,7 @@ | |||
"publish-preminor": "node scripts/clear-package-dir preminor --verbose && lerna publish preminor --pre-dist-tag=next --preid=next --force-publish --allow-branch=master --message=\"chore(release): Publish next pre-minor\"", | |||
"publish-next": "node scripts/clear-package-dir prerelease --verbose && lerna publish prerelease --pre-dist-tag=next --preid=next --allow-branch=master --message=\"chore(release): Publish next\"", | |||
"publish-rc": "node scripts/clear-package-dir prerelease --verbose && lerna publish prerelease --pre-dist-tag=rc --preid=rc --message=\"chore(release): Publish rc\"", | |||
"publish-release": "node scripts/clear-package-dir patch --verbose && lerna publish patch", | |||
"publish-release": "node scripts/clear-package-dir patch --verbose && lerna publish patch --dist-tag=latest-v2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about convention for that - but this is following one we had for v1 (latest-vX
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea if people actually use tags for this. I usually do npm install gatsby@^2.0.0
. So if we did latest-v1 in previous major, let's stick with it.
This is mainly for publishing purposes, because afaik dist-tag need to be set, and if not specified |
Description
V3 is out and this should be latest, but we still will be releasing patches for v2 so those stable releases should not be tagged as
latest