Added Babel dependency and configuration for building from ES6 codebase #31
Conversation
| @@ -23,7 +23,6 @@ | |||
| value.relativePath = path.relative('.', directory); | |||
| return globPages(directory, function(err, pagesData) { | |||
| value.pages = pagesData; | |||
| this.value = [value]; | |||
There was a problem hiding this comment.
Was this line not needed?
There was a problem hiding this comment.
Yeah, forgot I bumped my head over it for a while, might be some transformation that fails.
I'm not used to CoffeeScript now I understand that @ notation is the this scope binding notation (right?), but while executing with that line this error pops up:
Cannot set property 'value' of undefined
this is actually undefined(?).
For what I see the "value" is just passed in "callback" (wrapped as an array?).
|
Awesome! Made a few inline comments. LGTM. P.s. if you want to contribute more and would prefer to do so in ES6, feel free to convert |
|
Also, if you just want to port the starters to es6, that'd be cool too. That should be the default. I can fork the original version as an explicit Coffeescript starter. |
|
I'm willing to port the blog starter, if I get used to the quirks of porting might port the rest too. |
|
I ended up converting the whole blog starter |
|
Awesome! I'd love a PR for that to the starter blog repo. Will give more feedback later to this PR. |
|
Thanks! Merged and published https://github.com/gatsbyjs/gatsby/releases/tag/0.3.0 |
|
Awesome! |
|
Hiya @gesposito! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
* Delete TravisCI config * Remove gh-pages dependency and add prettier * Change double quotes to single quotes in src files * Update packages, refactor classes to stateless components and update readme * Removed package-lock as yarn is the default for this project * Readded travis yml * Remove travis config * Remove Eslint and Editorconfig * Remove html.js as it's already imported implicitely * Update lock file
I've made some config changes to let build from ES6 codebases as this one:
https://github.com/gesposito/gatsby-starter-blog
It's still hybrid (coffee, ES6) and just a proof of concept, but I'm willing to port it to a full ES6 starter.