fix(tests): update cheerio snapshots #31298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
|
looks like the Windows tests didn't run because CircleCI thought |
LekoArts
added
type: maintenance
vladar
pushed a commit
that referenced
this pull request
May 19, 2021
(cherry picked from commit e06599d) # Conflicts: # packages/gatsby-plugin-offline/package.json # packages/gatsby-remark-images/package.json # packages/gatsby-remark-prismjs/package.json
vladar
added a commit
that referenced
this pull request
May 19, 2021
(cherry picked from commit e06599d) # Conflicts: # packages/gatsby-plugin-offline/package.json # packages/gatsby-remark-images/package.json # packages/gatsby-remark-prismjs/package.json Co-authored-by: Adam Schay <[email protected]>
axe312ger
pushed a commit
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cheerio v1.0.0-rc.6introduced some slight parsing differences that have no impact on production code but cause tests to fail. Today's merger of #31163 did not account for the snapshot updates and only updated thepackage.jsonofgatsby-remark-copy-linked-files, but it dedupedcheeriofor the monorepo tov1.0.0-rc.9and thus broke testing. This PR updatescheerioin all packages tov1.0.0-rc.9and updates the failing snapshots.