fix(gatsby): Pass reporter from functions code for reporting warning #31336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also include the file that the warning is for in the message
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: functions
and removed
status: triage needed
KyleAMathews
commented
May 7, 2021
| @@ -148,7 +148,9 @@ export const reportWebpackWarnings = ( | |||
| warnings: StatsCompilation["warnings"] = [], | |||
| reporter: Reporter | |||
| ): void => { | |||
| const warningMessages = warnings.map(warning => warning.message) | |||
| const warningMessages = warnings.map( | |||
| warning => `${warning.moduleName}\n\n${warning.message}` | |||
There was a problem hiding this comment.
make the warning a lot more useful — say which file it's from.
Thinking we don't need formatWebpackMessages any more w/ webpack 5? We just pass it a string which it now returns... 🤷
Warnings look like this now:
There was a problem hiding this comment.
formatWebpackMessages does more than formatting. It also rewrites errors to a more actionable ones.
There was a problem hiding this comment.
The stats warnings/error object changed in v5 — see #30801 & facebook/create-react-app#9943
There was a problem hiding this comment.
but yeah, to your point, the message rewritings should still apply so we still want it
wardpeet
reviewed
May 10, 2021
Co-authored-by: Ward Peeters <[email protected]>
wardpeet
approved these changes
May 11, 2021
vladar
pushed a commit
that referenced
this pull request
May 11, 2021
…31336) * fix(gatsby): Pass reporter from functions code for reporting warning Also include the file that the warning is for in the message * Update packages/gatsby/src/internal-plugins/functions/gatsby-node.ts Co-authored-by: Ward Peeters <[email protected]> Co-authored-by: Ward Peeters <[email protected]> (cherry picked from commit f09fae8)
vladar
pushed a commit
that referenced
this pull request
May 11, 2021
…31336) (#31363) * fix(gatsby): Pass reporter from functions code for reporting warning Also include the file that the warning is for in the message * Update packages/gatsby/src/internal-plugins/functions/gatsby-node.ts Co-authored-by: Ward Peeters <[email protected]> Co-authored-by: Ward Peeters <[email protected]> (cherry picked from commit f09fae8) Co-authored-by: Kyle Mathews <[email protected]>
axe312ger
pushed a commit
that referenced
this pull request
May 20, 2021
…31336) * fix(gatsby): Pass reporter from functions code for reporting warning Also include the file that the warning is for in the message * Update packages/gatsby/src/internal-plugins/functions/gatsby-node.ts Co-authored-by: Ward Peeters <[email protected]> Co-authored-by: Ward Peeters <[email protected]>
LekoArts
added
the
topic: DX
This was referenced Mar 13, 2022
This was referenced Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also include the file that the warning is for in the message.
Fix for #30735 (comment)