Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gatsby-source-drupal to match new json api endpoint #3136

Merged
merged 2 commits into from
Dec 12, 2017

Conversation

tcfunk
Copy link

@tcfunk tcfunk commented Dec 5, 2017

Drupal JSON API has changed their endpoint base from api to jsonapi. This updates gatsby-source-drupal to match this, and allows override to old endpoint if necessary.

See https://www.drupal.org/docs/8/modules/json-api/api-overview

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 5, 2017

Deploy preview ready!

Built with commit 19ac0fe

https://deploy-preview-3136--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 5, 2017

Deploy preview ready!

Built with commit 19ac0fe

https://deploy-preview-3136--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Looks great, thanks!

Could you document this in the README e.g. what version of json-api made the change + how to set the apibase?

@tcfunk
Copy link
Author

tcfunk commented Dec 6, 2017

Yeah, sure. Not sure about the jsonapi version but I can do some digging.

@tcfunk
Copy link
Author

tcfunk commented Dec 7, 2017

Added some documentation, let me know if it's what you're looking for or if you have some further suggestions. Thanks!

@tcfunk
Copy link
Author

tcfunk commented Dec 12, 2017

Just pinging this in case it got lost. Let me know if there's more I can do to get the change accepted, I could really use the update for my current project :)

@KyleAMathews
Copy link
Contributor

Really sorry about the slow merge — been crazy busy last week or so. Merging and publishing! Hopefully you can share the project once it's done! Would love to see what you build :-)

@KyleAMathews KyleAMathews merged commit ba36de9 into gatsbyjs:master Dec 12, 2017
@tcfunk
Copy link
Author

tcfunk commented Dec 14, 2017

No worries, I can identify with having a crazy week :) Thanks for the merge!

@jlengstorf
Copy link
Contributor

Hiya @tcfunk! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants