Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/gatsby remark code repls add ramda #3171

Conversation

Undistraction
Copy link
Contributor

@Undistraction Undistraction commented Dec 9, 2017

Add support for loading code into Ramda REPL to gatsby-remark-code-repls.

Ref #3156

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 9, 2017

Deploy preview ready!

Built with commit f947a1a

https://deploy-preview-3171--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Dec 9, 2017

Deploy preview ready!

Built with commit cbcc196

https://deploy-preview-3171--using-drupal.netlify.com

@Undistraction
Copy link
Contributor Author

Hold fire on this. Found an issue.

@Undistraction
Copy link
Contributor Author

OK. It's good to go.

@KyleAMathews
Copy link
Contributor

/cc @bvaughn

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍


verifyFile(filePath)

// Don't use `compress()` as the Ramda REPL won't understand the output. It uses URI to encode the code for its urls, so we do the same.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Long line. Break into 2?

@ghost ghost assigned KyleAMathews Dec 13, 2017
@ghost ghost added the review label Dec 13, 2017
@KyleAMathews KyleAMathews merged commit 23f156d into gatsbyjs:master Dec 13, 2017
@ghost ghost removed the review label Dec 13, 2017
@KyleAMathews
Copy link
Contributor

Thanks!

mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
* Add support for Ramda REPL via ramda:// link protocol

* Update docs to include Ramda REPL

* fix: Bad protocol constant

* Fix overlong comment

* Format and ignore compiled file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants