Fix page hot loading fixes #3255 #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Deploy preview ready! Built with commit bce8b30 |
|
In #3237 I added But I forgot that This PR restores listening to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3237 I added
CREATE_PAGE_ENDas cleaner way to know when pages are finished being added and stopped listening toCREATE_PAGEas it's really noisy and sometimes leads to extra writes.But I forgot that
CREATE_PAGE_ENDwon't always be called as plugins implementingcreatePagesStagefullycan create pages whenever so we still need to listen toCREATE_PAGES.This PR restores listening to
CREATE_PAGEbut only after bootstrap is finished.