chore(gatsby-remark-images): Only convert supported image extensions #32868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
suggested changes
Aug 23, 2021
There was a problem hiding this comment.
Thanks for the PR!
Can you please also add tests for this to https://github.com/Mike-Dax/gatsby/blob/only-convert-images/packages/gatsby-remark-images/src/__tests__/index.js to check the correct behavior?
Let me know if you need any help
LekoArts
added
topic: remark/mdx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby-remark-imageswill incorrectly attempt to convert videos and other files, only disallowing gifs and svgs. This PR adds an explicit allow list instead.This helps it play nicer with plugins such as
gatsby-remark-videos.