Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): remove unused packages #32903

Merged
merged 3 commits into from
Aug 26, 2021
Merged

chore(gatsby): remove unused packages #32903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9254e65
chore(gatsby): remove unused packages
wardpeet Aug 25, 2021
8e0af6e
re-add mitt
wardpeet Aug 25, 2021
dac6aed
fix ssr test :shrug:
wardpeet Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration-tests/ssr/__tests__/ssr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe(`SSR`, () => {
test(`dev & build outputs match`, async () => {
const childProcess = await execa(`yarn`, [`test-output`])

expect(childProcess.code).toEqual(0)
expect(childProcess.exitCode).toEqual(0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this change was necessary but code returns undefined


// Additional sanity-check
expect(String(childProcess.stdout)).toContain(
Expand Down
1 change: 1 addition & 0 deletions integration-tests/ssr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"devDependencies": {
"cheerio": "^1.0.0-rc.9",
"cross-env": "^5.0.2",
"execa": "^5.1.1",
"fs-extra": "^9.0.0",
"gatsby-core-utils": "^2.12.0",
"jest": "^24.0.0",
Expand Down
9 changes: 1 addition & 8 deletions packages/gatsby/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"common-tags": "^1.8.0",
"compression": "^1.7.4",
"cookie": "^0.4.1",
"copyfiles": "^2.3.0",
"core-js": "^3.9.0",
"cors": "^2.8.5",
"css-loader": "^5.0.1",
Expand Down Expand Up @@ -98,7 +97,6 @@
"is-relative-url": "^3.0.0",
"joi": "^17.2.1",
"json-loader": "^0.5.7",
"json-stringify-safe": "^5.0.1",
"latest-version": "5.1.0",
"lodash": "^4.17.21",
"md5-file": "^5.0.0",
Expand All @@ -108,10 +106,8 @@
"mime": "^2.4.6",
"mini-css-extract-plugin": "1.6.2",
"mitt": "^1.2.0",
"mkdirp": "^0.5.1",
"moment": "^2.27.0",
"multer": "^1.4.2",
"name-all-modules-plugin": "^1.0.1",
"normalize-path": "^3.0.0",
"null-loader": "^4.0.1",
"opentracing": "^0.14.4",
Expand All @@ -120,7 +116,6 @@
"path-to-regexp": "0.1.7",
"physical-cpu-count": "^2.0.0",
"platform": "^1.3.6",
"pnp-webpack-plugin": "^1.6.4",
"postcss": "^8.3.5",
"postcss-flexbugs-fixes": "^5.0.2",
"postcss-loader": "^5.0.0",
Expand Down Expand Up @@ -151,12 +146,10 @@
"true-case-path": "^2.2.1",
"type-of": "^2.0.1",
"url-loader": "^4.1.1",
"util.promisify": "^1.0.1",
"uuid": "3.4.0",
"v8-compile-cache": "^2.2.0",
"webpack": "^5.35.0",
"webpack-dev-middleware": "^4.1.0",
"webpack-dev-server": "^3.11.2",
"webpack-merge": "^5.7.3",
"webpack-stats-plugin": "^1.0.3",
"webpack-virtual-modules": "^0.3.2",
Expand All @@ -166,7 +159,6 @@
"devDependencies": {
"@babel/cli": "^7.14.8",
"@babel/register": "^7.14.0",
"@babel/runtime": "^7.14.8",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also in dependencies

"@types/eslint": "^7.2.6",
"@types/micromatch": "^4.0.1",
"@types/normalize-path": "^3.0.0",
Expand All @@ -178,6 +170,7 @@
"@types/tmp": "^0.2.0",
"@types/webpack-virtual-modules": "^0.1.1",
"babel-preset-gatsby-package": "^1.13.0-next.0",
"copyfiles": "^2.3.0",
"cross-env": "^7.0.3",
"documentation": "^13.1.0",
"enhanced-resolve": "^4.2.0",
Expand Down
Loading