-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove <title> from inside <main> #33150
Merged
KyleAMathews
merged 1 commit into
master
from
remove-title-tag-from-functions-hello-world
Sep 12, 2021
Merged
Remove <title> from inside <main> #33150
KyleAMathews
merged 1 commit into
master
from
remove-title-tag-from-functions-hello-world
Sep 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this example is for functions, this title is not really necessary. A <title> should only be used inside a <head>, but adding react-helmet or dynamically setting the page title is not necessary here.
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 11, 2021
KyleAMathews
approved these changes
Sep 12, 2021
KyleAMathews
deleted the
remove-title-tag-from-functions-hello-world
branch
September 12, 2021 05:23
LekoArts
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 20, 2021
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jan 31, 2023
This was referenced Jan 31, 2023
This was referenced Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this example is for functions, this title is not really necessary. A <title> should only be used inside a , but adding react-helmet or dynamically setting the page title is not necessary here.
Description
Documentation
Related Issues