Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-drupal): check relationships type exists on node before filtering (#33181) #33228

Merged
merged 1 commit into from
Sep 17, 2021
Merged

fix(gatsby-source-drupal): check relationships type exists on node before filtering (#33181) #33228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/gatsby-source-drupal/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const {
nodeFromData,
downloadFile,
isFileNode,
getHref,
createNodeIdWithVersion,
} = require(`./normalize`)

Expand Down Expand Up @@ -262,10 +261,15 @@ ${JSON.stringify(nodeToUpdate, null, 4)}

const nodeFieldName = `${newNode.internal.type}___NODE`
removedReferencedNodes.forEach(referencedNode => {
referencedNode.relationships[nodeFieldName] =
referencedNode.relationships[nodeFieldName].filter(
id => id !== newNode.id
)
if (
referencedNode.relationships &&
referencedNode.relationships[nodeFieldName]
) {
referencedNode.relationships[nodeFieldName] =
referencedNode.relationships[nodeFieldName].filter(
id => id !== newNode.id
)
}
})

// see what nodes are newly referenced, and make sure to call `createNode` on them
Expand Down