-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-drupal): Add node manifest support for previews #33683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Oct 26, 2021
pvorozhe
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Oct 26, 2021
DanielSLew
reviewed
Oct 26, 2021
DanielSLew
reviewed
Oct 26, 2021
kathmbeck
reviewed
Oct 27, 2021
…ithub.com/gatsbyjs/gatsby into pvorozhe/drupal-add-node-manifest-support
LekoArts
added
the
topic: source-drupal
Related to Gatsby's integration with Drupal
label
Nov 1, 2021
TylerBarnes
requested review from
KyleAMathews,
kathmbeck,
DanielSLew and
TylerBarnes
November 1, 2021 18:49
TylerBarnes
reviewed
Nov 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 💪 @KyleAMathews @DanielSLew any thoughts before we approve/merge?
veryspry
reviewed
Nov 5, 2021
veryspry
approved these changes
Nov 5, 2021
The failing tests are unrelated, going to merge. Thanks for this @pvorozhe ! |
axe312ger
pushed a commit
that referenced
this pull request
Nov 9, 2021
…33683) * Drupal plugin: Add node manifest support.
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.