Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Reorder head tags #34030

Merged
merged 9 commits into from
Dec 17, 2021
Merged

fix(gatsby): Reorder head tags #34030

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
43299d8
group head tags and reorder and spread
graysonhicks Nov 19, 2021
b757f66
move tag ordering to static-entry
graysonhicks Dec 1, 2021
5575607
Merge branch 'gatsbyjs:master' into feature/react-helmet-sort-tags
graysonhicks Dec 1, 2021
7b4c545
change reduce to sort
graysonhicks Dec 6, 2021
8d905e5
comment purpose of headComponents sort
graysonhicks Dec 7, 2021
2f510cd
Merge branch 'master' into feature/react-helmet-sort-tags
graysonhicks Dec 7, 2021
38506b8
Merge branch 'gatsbyjs:master' into feature/react-helmet-sort-tags
graysonhicks Dec 13, 2021
694b7b9
Merge branch 'gatsbyjs:master' into feature/react-helmet-sort-tags
graysonhicks Dec 14, 2021
4ec7665
Merge branch 'gatsbyjs:master' into feature/react-helmet-sort-tags
graysonhicks Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/gatsby/cache-dir/static-entry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,16 @@ export default async function staticPage({

postBodyComponents.push(...bodyScripts)

// Reorder headComponents so meta tags are always at the top and aren't missed by crawlers
// by being pushed down by large inline styles, etc.
// https://github.com/gatsbyjs/gatsby/issues/22206
headComponents.sort((a, b) => {
if (a.type && a.type === `meta`) {
return -1
}
return 0
})

apiRunner(`onPreRenderHTML`, {
getHeadComponents,
replaceHeadComponents,
Expand Down