Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(gatsby): Trailing slash client only splat #34538

Merged
merged 9 commits into from
Jan 24, 2022
Merged

test(gatsby): Trailing slash client only splat #34538

merged 9 commits into from
Jan 24, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Jan 19, 2022 •
edited
Loading

Description

  • Adds test case for trailing slash client only splat case
  • Removes a couple duplicated tests
  • Adjusts names and logically groups splat cases (one in fs-api and new one in client-only-splat)

Note

Colocating [...name].js and [name].js in the same client-only directory as directed in the ticket did not work. Nested routes (e.g. /client-only/hello/world) did not exist. Created separate client-only-splat directory to test client only splat separately.

If this is expected, I may update the documentation to note this. Otherwise it may be something to investigate.

Related Issues

  • [sc-44588]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 19, 2022
@tyhopp tyhopp added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 19, 2022
@tyhopp tyhopp changed the title test(gatsby): trailing slash client only splat test(gatsby): Trailing slash client only splat Jan 19, 2022
@tyhopp tyhopp added this to the Trailing Slash milestone Jan 19, 2022
LekoArts
LekoArts suggested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests for direct visits are good 👍 We'll want to add tests for visits with <Link> component, too

e2e-tests/trailing-slash/cypress/integration/always.js Show resolved Hide resolved
@tyhopp tyhopp requested a review from LekoArts January 20, 2022 02:45
@tyhopp tyhopp mentioned this pull request Jan 20, 2022
Merged
@LekoArts LekoArts merged commit dd8cc06 into trailing-slash Jan 24, 2022
@LekoArts LekoArts deleted the test-trailing-slash-client-only-splat branch January 24, 2022 08:19
@LekoArts LekoArts mentioned this pull request Jan 26, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Milestone
Trailing Slash
Development

Successfully merging this pull request may close these issues.
2 participants
@tyhopp @LekoArts