Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Local file lookups in eq: $id queries #34699

Merged
merged 3 commits into from
Feb 3, 2022
Merged

fix(gatsby): Local file lookups in eq: $id queries #34699

merged 3 commits into from
Feb 3, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Feb 3, 2022 •
edited
Loading

Description

The PR #34520 introduced a regression, see #34693

This fixes it.

Related Issues

Fixes #34693
[ch45642]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 3, 2022
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 3, 2022
@LekoArts LekoArts changed the title fix(gatsby): TODO fix(gatsby): Local file lookups Feb 3, 2022
@LekoArts LekoArts changed the title fix(gatsby): Local file lookups fix(gatsby): Local file lookups in eq: $id queries Feb 3, 2022
pieh
pieh previously approved these changes Feb 3, 2022
View reviewed changes
@pieh pieh added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 3, 2022
@LekoArts LekoArts mentioned this pull request Feb 3, 2022
Closed
2 tasks
pieh
pieh previously approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve after adding tests

pieh
pieh approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-re-approve

@gatsbybot gatsbybot merged commit 23accf4 into master Feb 3, 2022
@gatsbybot gatsbybot deleted the issue-34693 branch February 3, 2022 19:53
@gatsbybot gatsbybot mentioned this pull request Feb 4, 2022
Merged
LekoArts added a commit that referenced this pull request Feb 4, 2022
@LekoArts
fix(gatsby): Local file lookups in eq: $id queries (#34699)
907b289 
* initial

* add unit test for eq.id and fileByRelativePath

* fix windows unit tests

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 23accf4)
LekoArts added a commit that referenced this pull request Feb 4, 2022
@gatsbybot @pieh @LekoArts
fix(gatsby): Local file lookups in eq: $id queries (#34699) (#34717)
7c2f404 
Co-authored-by: Michal Piechowiak <[email protected]>
Co-authored-by: Lennart <[email protected]>
@marvinjude
Copy link
Contributor

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'dir') when using GatsbyImage
4 participants
@LekoArts @marvinjude @pieh @gatsbybot