chore: e2e/integration with React 17 & 18 #35320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
type: maintenance
LekoArts
changed the title
|
Ok, this has been a deep rabbit hole. The production runtime tests failed with the lifecycle tests because The hydration error doesn't occur in minimal reproduction project, only when you use For now these tests will be changed with a TODO and #35226 then needs to actually fix the image error and revert the test changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Runs development-runtime and production-runtime with React 18 in addition to React 17.
This PR also removes the outdated nightly jobs (no one looked at them + the slack setup was removed).
It also updates all e2e/integration tests to run with React 17.
[ch48484]