Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): Ensure min 1px height for BLURRED placeholder #35914

Merged
merged 5 commits into from
Jul 26, 2022
Merged

fix(gatsby-plugin-sharp): Ensure min 1px height for BLURRED placeholder #35914

merged 5 commits into from
Jul 26, 2022

Conversation

ThomasVandenhede
Copy link
Contributor

@ThomasVandenhede ThomasVandenhede commented Jun 10, 2022 •
edited by LekoArts
Loading

Description

Enforce a 1px min height for base64 blurred placeholder images, even for very elongated pictures (> 20:1 aspect ratio).

Related Issues

Fixes #35910

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 10, 2022
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 13, 2022
@LekoArts LekoArts changed the title fix(gatsby-plugin-sharp): ensure min 1px height for blurred base64 images fix(gatsby-plugin-sharp): Ensure min 1px height for BLURRED placeholder Jun 13, 2022
@LekoArts
Copy link
Contributor

Thanks for the PR!

Let's add a test case to

gatsby/packages/gatsby-plugin-sharp/src/__tests__/index.js

Line 526 in f2a65e1

describe(`image quirks`, () => {
to make sure we don't regress. Let me know if you need any assistance.

LekoArts
LekoArts previously approved these changes Jul 26, 2022
View reviewed changes
@LekoArts LekoArts merged commit abad94f into gatsbyjs:master Jul 26, 2022
@kaocher82 kaocher82 mentioned this pull request Oct 27, 2023
Open
@saurabharch saurabharch mentioned this pull request Oct 27, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Oct 27, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Oct 27, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Oct 27, 2023
Open
@monizb monizb mentioned this pull request Oct 27, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Oct 27, 2023
Open
@wizbit wizbit mentioned this pull request Oct 27, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Oct 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Oct 28, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Oct 28, 2023
Open
@monizb monizb mentioned this pull request Oct 28, 2023
Open
@joeawillis joeawillis mentioned this pull request Oct 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Oct 28, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 14, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Dec 14, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Dec 15, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Jan 5, 2024
Open
@monizb monizb mentioned this pull request Jan 5, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 5, 2024
Open
@impactyogi impactyogi mentioned this pull request Jan 5, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 5, 2024
Open
@joeawillis joeawillis mentioned this pull request Jan 6, 2024
Open
@monizb monizb mentioned this pull request Jan 6, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Jan 6, 2024
Open
@saurabharch saurabharch mentioned this pull request Jan 6, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Jan 6, 2024
Open
@joeawillis joeawillis mentioned this pull request Jan 6, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Jan 6, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Jan 6, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 6, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Feb 22, 2024
Open
@monizb monizb mentioned this pull request Feb 22, 2024
Open
@Rutam21 Rutam21 mentioned this pull request Feb 22, 2024
Open
@joeawillis joeawillis mentioned this pull request Feb 23, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Feb 23, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Feb 23, 2024
Open
@impactyogi impactyogi mentioned this pull request Feb 23, 2024
Open
@saurabharch saurabharch mentioned this pull request Feb 23, 2024
Open
This was referenced Feb 23, 2024
Open
Open
Open
@monizb monizb mentioned this pull request Feb 23, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Feb 23, 2024
Open
@nidhi42 nidhi42 mentioned this pull request Feb 23, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Feb 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-plugin-sharp "height has to be a positive int larger than zero (> 0), now it's 0"
2 participants
@ThomasVandenhede @LekoArts