Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-source-wordpress): Add retries to graphql requests #35949

Merged
merged 8 commits into from
Jun 30, 2022
Merged

feat(gatsby-source-wordpress): Add retries to graphql requests #35949

merged 8 commits into from
Jun 30, 2022

Conversation

TylerBarnes
Copy link
Contributor

This PR adds 5 retries to all WordPress GraphQL requests that fail with a 500, 502, 503, or 504 error.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 17, 2022
@TylerBarnes TylerBarnes removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 17, 2022
@LekoArts LekoArts added topic: source-wordpress Related to Gatsby's integration with WordPress topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) labels Jun 21, 2022
@imjoshin
Copy link
Contributor

Looks good to me, pending test updates!

veryspry
veryspry approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@TylerBarnes TylerBarnes added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 30, 2022
@TylerBarnes
Copy link
Contributor Author

The failing tests are unrelated and seem to be a problem with package resolution: error Couldn't find package "scheduler@^0.20.2" required by "react-dom@^17.0.2" on the "npm" registry.. I can confirm that the related tests are passing so I'm going to merge.

@TylerBarnes TylerBarnes merged commit 48a64f6 into master Jun 30, 2022
@TylerBarnes TylerBarnes deleted the feat/wp-retries branch June 30, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veryspry veryspry veryspry approved these changes

@imjoshin imjoshin Awaiting requested review from imjoshin

Assignees

@veryspry veryspry

@DanielSLew DanielSLew

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-plugins Relates to the Gatsby source plugins (e.g. -filesystem) topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TylerBarnes @imjoshin @veryspry @LekoArts @DanielSLew