Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): convert babel-loaders to typescript #36318

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

Kornil
Copy link
Contributor

@Kornil Kornil commented Aug 4, 2022

Convert babel-loaders to TS.

Related Issues

#21995

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 4, 2022
@Kornil Kornil changed the title chore(gatsby): convert babel-loadera to typescript chore(gatsby): convert babel-loaders to typescript Aug 4, 2022
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 4, 2022
@Kornil
Copy link
Contributor Author

Kornil commented Aug 4, 2022

Thanks for the import changes @LekoArts I was not sure how to proceed since it was dynamically imported.
I checked the tests and they still seem unrelated e2e tests.

@imjoshin
Copy link
Contributor

imjoshin commented Aug 9, 2022

Thanks for the import changes @LekoArts I was not sure how to proceed since it was dynamically imported. I checked the tests and they still seem unrelated e2e tests.

We have a few tests that are notoriously flaky that we're trying to resolve. I think they're all unrelated... I kicked them off again.

Thank you for your contribution 💜

@Kornil
Copy link
Contributor Author

Kornil commented Aug 10, 2022

I'm quite unlucky with these tests, I've checked them again to be safe, mostly remote-file.js that seem to be a common one across all my PRs (unrelated) and something from gatsby-script that seem unrelated as well.

@imjoshin
Copy link
Contributor

@Kornil thanks again for going through the rebase. We appreciate all that you do!

@imjoshin imjoshin merged commit fe1d2e1 into gatsbyjs:master Aug 11, 2022
@Kornil Kornil deleted the convert-babel-loaders-to-typescript branch August 11, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants