-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup v5 release channel #36540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 5, 2022
wardpeet
added
type: maintenance
An issue or pull request describing a change that isn't a bug, feature or documentation change
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Sep 5, 2022
This here also needs an update, right?
|
@TylerBarnes What about https://github.com/gatsbyjs/gatsby/blob/7fe8e511b0dcd1707eefca2c63b0f27174d7252c/packages/gatsby-source-wordpress/src/utils/gatsby-version.ts, can this be changed to just behave normal now? |
The above we want to keep as is; it's the default that we run with. |
wardpeet
force-pushed
the
chore/v5-setup
branch
from
September 6, 2022 10:22
2a1495d
to
a999a50
Compare
LekoArts
reviewed
Sep 6, 2022
wardpeet
force-pushed
the
chore/v5-setup
branch
from
September 7, 2022 08:22
8813d26
to
f2af76b
Compare
wardpeet
force-pushed
the
chore/v5-setup
branch
from
September 7, 2022 08:42
00d3ebd
to
c74c6d1
Compare
LekoArts
approved these changes
Sep 7, 2022
This was referenced Sep 13, 2022
This was referenced Sep 14, 2022
This was referenced Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: maintenance
An issue or pull request describing a change that isn't a bug, feature or documentation change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setup Gatsby v5 alpha channel. It's similar to our v4 release. We merge everything in master behind
_CFLAGS_.MAJOR
, this allows us to make breaking changes when publishing v5 but keeping v4 channel working.We should use
_CFLAGS_.MAJOR
for all things that's javascript based. For other related files we can usegit patches
that auto apply in order.