Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tracedSVG (#37093) #37137

Merged
merged 12 commits into from
Dec 6, 2022
Merged

chore: remove tracedSVG (#37093) #37137

merged 12 commits into from
Dec 6, 2022

Conversation

gatsbybot
Copy link
Collaborator

Backporting #37093 to the 3.15 release branch

(cherry picked from commit 94c2d73)

* init

* gri

* update shopify snapshot

* gatsby-plugin-sharp tests

* update gatsby-remark-images/gatsby-node tests

* update gatsby-plugin-image tests

* update schema print tests

* remove traceSVG unit tests as it was removed

* legacy gatsby-image fields

* update polyfill tests

* update cypress assertion

* update contentful cypress assertions

* drop few more packages from gatsby-plugin-sharp as they are no onger used

* correct IMAGE_CDN fallback for TRACE_SVG

* update generateImageData

* update e2e-prod/assertions

* update unit test

* update snapshot

* update e2e-dev/assertions

* drop more unused

* sync yarn.lock

* a bit more prod warnings

* adjust gatsby-remark-images plugin options warning

* add link to gatsby-remark-images warning

(cherry picked from commit 94c2d73)
@pieh pieh merged commit 0c45654 into release/3.15 Dec 6, 2022
@pieh pieh deleted the backport-3.15-37093 branch December 6, 2022 17:10
pieh pushed a commit that referenced this pull request Dec 7, 2022
* chore: remove tracedSVG (#37093)

* init

* gri

* update shopify snapshot

* gatsby-plugin-sharp tests

* update gatsby-remark-images/gatsby-node tests

* update gatsby-plugin-image tests

* update schema print tests

* remove traceSVG unit tests as it was removed

* legacy gatsby-image fields

* update polyfill tests

* update cypress assertion

* update contentful cypress assertions

* drop few more packages from gatsby-plugin-sharp as they are no onger used

* correct IMAGE_CDN fallback for TRACE_SVG

* update generateImageData

* update e2e-prod/assertions

* update unit test

* update snapshot

* update e2e-dev/assertions

* drop more unused

* sync yarn.lock

* a bit more prod warnings

* adjust gatsby-remark-images plugin options warning

* add link to gatsby-remark-images warning

(cherry picked from commit 94c2d73)

* gatsby recipe tests

* cli tests

* babel config tests

* update assertion

* some reverts?

* update assertion

* contentful extend node type

* fallback in test

* fix tracedSVG fields

* fix(gatsby-cli): relax error location validation and ignore extra fields (#34559)

* package.json removals

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 0c45654)
@maxmellen
Copy link

Hi @pieh 👋
Is this the only change in Gatsby 3.15?
I can't find any changelog related to that version and it somehow fixes a dev server restart issue I was having on a legacy project.
Happy to provide more details if you like but I was hoping to first better understand what changed in this version.
Thanks :)

@pieh
Copy link
Contributor

pieh commented Dec 9, 2022

Hey @maxmellen!

I can't find any changelog related to that version

The main reason for this change is related to #37104

Which we basically have to do for all major versions

it somehow fixes a dev server restart issue I was having on a legacy project

I did "backport" few other fixes and improvements to get as much tests to pass again and one of those ( c275c20 ) is likely responsible for fixing some potential dev server crashes when there is compilation / transpilation errors (tho hard to say if this is what fixed a problem for you without knowing more about your particular issue )

@maxmellen
Copy link

Hey, thanks a lot for such a quick response!
Really appreciate the extra context! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants