fix(gatsby): handle initializing multiple instances of gatsby-plugin-sharp #37306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
pieh
changed the title
tyhopp
reviewed
Dec 22, 2022
| @@ -26,6 +26,7 @@ import { store } from "../../redux" | |||
| import { validateEngines } from "../../utils/validate-engines" | |||
|
|
|||
| async function run(): Promise<void> { | |||
| process.env.GATSBY_SLICES = `1` | |||
There was a problem hiding this comment.
Double checking, is this change also required for the fix or left in accidentally?
There was a problem hiding this comment.
This is not needed for a fix as we don't actually use this file in regular usage.
I just noticed problems with trying to use engines regenerated with this script manually as I was iterating on this PR and testing produced engines
tyhopp
approved these changes
Dec 22, 2022
pieh
added a commit
that referenced
this pull request
Dec 23, 2022
…sharp (#37306) * fix(gatsby): handle initializing multiple instances of gatsby-plugin-sharp * fix(gatsby): handle initializing multiple instances of gatsby-plugin-sharp in engines * update standalone-regenerate * normalize main config when loading themes * move deduplicaiton to plugin loading instead of themes loading * convert load-themes to TS * lint * update assertions * remove test that no longer make sense (cherry picked from commit 26f2b72)
pieh
added a commit
that referenced
this pull request
Dec 23, 2022
…sharp (#37306) * fix(gatsby): handle initializing multiple instances of gatsby-plugin-sharp * fix(gatsby): handle initializing multiple instances of gatsby-plugin-sharp in engines * update standalone-regenerate * normalize main config when loading themes * move deduplicaiton to plugin loading instead of themes loading * convert load-themes to TS * lint * update assertions * remove test that no longer make sense (cherry picked from commit 26f2b72)
pieh
added a commit
that referenced
this pull request
Dec 23, 2022
…sharp (#37306) * fix(gatsby): handle initializing multiple instances of gatsby-plugin-sharp * fix(gatsby): handle initializing multiple instances of gatsby-plugin-sharp in engines * update standalone-regenerate * normalize main config when loading themes * move deduplicaiton to plugin loading instead of themes loading * convert load-themes to TS * lint * update assertions * remove test that no longer make sense (cherry picked from commit 26f2b72)
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 27, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for
errors when there's multiple instances of gatsby-plugin-sharp package (for themes scenarios, when there might be different versions and package manager doesn't or can't dedupe)
Explanation of changes:
gatsby-plugin-sharpwhich most often doesn't have any options and was deduped because it's specified just asgatsby-plugin-sharp- this meant that some instances ofgatsby-plugin-sharpwere not initiated at all. This PR moves it to after we resolve plugins where we can check actual plugin packages instances when deduping. This also required update toimport-gatsby-pluginto be able to not just use plugin name, but different identifier - forgatsby build/developwe rely onplugin.resolveproperty. I did have to keep fallback tonameforgatsby-worker, as when trying to use it we are losing which instance it is for.resolveproperty from engines I needed yet another way to adjustimport-gatsby-pluginand used simpleimportKeywhich is 1-indexed counter (and it represent just the index of plugin in the plugins listload-themes/index.jsto typescriptDocumentation
Related Issues