chore(gatsby): Improve SlicePlaceholderProps type #37409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: TypeScript
marvinjude
approved these changes
Jan 5, 2023
This was referenced Jan 10, 2023
This was referenced Jan 10, 2023
This was referenced Jan 10, 2023
This was referenced Jan 11, 2023
This was referenced Feb 16, 2023
This was referenced Feb 18, 2023
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've found https://stackoverflow.com/questions/75017011/gatsby-5-ts-and-new-slice-component and it's a valid bug:
The root cause is the lack of this feature request that would allow our intended usage: microsoft/TypeScript#17867
So we're sacrificing some type guards here but all the proposed solutions in the issue and on SO didn't work.
Documentation
No update needed
Related Issues
[ch59899]