-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Restore asset, path prefix for file-loader handled files #37429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jan 10, 2023
tyhopp
added
topic: render-mode
Related to Gatsby's different rendering modes
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Jan 10, 2023
tyhopp
changed the title
fix(gatsby): Preserve asset, path prefix
fix(gatsby): Restore asset, path prefix
Jan 10, 2023
tyhopp
changed the title
fix(gatsby): Restore asset, path prefix
fix(gatsby): Restore asset, path prefix for file-loader handled files
Jan 10, 2023
LekoArts
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With tests, nice!
LekoArts
pushed a commit
that referenced
this pull request
Jan 10, 2023
…#37429) (#37430) Co-authored-by: Ty Hopp <[email protected]>
This was referenced Jan 10, 2023
2 tasks
This was referenced Feb 16, 2023
This was referenced Feb 18, 2023
This was referenced Apr 24, 2023
pastepi
pushed a commit
to pastepi/gatsby
that referenced
this pull request
Dec 16, 2023
pieh
pushed a commit
that referenced
this pull request
Dec 19, 2023
…#38764) * fix(gatsby): Restore asset, path prefix for file-loader handled files (#37429) * add missing import, read vars from config --------- Co-authored-by: Ty Hopp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #37284 we stopped duplicate output of files, but also removed the ability to set
assetPrefix
andpathPrefix
for files handled byfile-loader
. This change restores that functionality.Documentation
N/A
Related Issues
Fixes #37427