fix(gatsby): nodeModel.findAll supports v5 sort argument structure #37477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: GraphQL
LekoArts
approved these changes
Jan 17, 2023
LekoArts
pushed a commit
that referenced
this pull request
Jan 17, 2023
…37477) (#37479) Co-authored-by: Michal Piechowiak <[email protected]>
|
Published in |
This was referenced Jan 24, 2023
This was referenced Jan 25, 2023
This was referenced Jan 25, 2023
laurenskling
added a commit
to laurenskling/gatsby
that referenced
this pull request
Sep 1, 2023
As per gatsbyjs#37477, the nodeModel can use the new sort syntax
pieh
pushed a commit
that referenced
this pull request
Sep 7, 2023
As per #37477, the nodeModel can use the new sort syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
context.nodeModel.findAllcurrently doesn't work with newsortsyntax/structure - it still expects olds syntax withfieldsandorderfields which was largely based as-is in #36708 as we only changed "front" in graphql schema and immediately converted to old structures for internal processing, but just in our resolver.nodeModelstill expects old structure today, which shold be considered a bug.Documentation
Related Issues
[sc-60184]